mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.
Date Tue, 10 Nov 2015 14:05:23 GMT


> On Oct. 13, 2015, 3:35 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, line 60
> > <https://reviews.apache.org/r/38059/diff/3/?file=1088987#file1088987line60>
> >
> >     Should we follow the pattern of other validation routines where we use the validation
namespace and pull these utility routines into a separate file?
> >     
> >     I think we can separate the validation of the request from the content of the
protobuf. Syntax vs. semantic.
> >     
> >     See maintenance as an example.
> 
> Alexander Rukletsov wrote:
>     The reason it's conflated into one function is because in order to do proper validation
we should convert JSON to protobuf. Some checks are performed with the JSON object and some
with the converted protobuf. I though that having three functions `validateJSON`, `convertToQuotaInfo`,
and `validateQuotaInfo` is too much.
> 
> Joseph Wu wrote:
>     What specific validation are you doing to the JSON objects (other than converting
to Protobuf)?  And why can't the validation wait until after the JSON->Protobuf conversion
sufficient?
> 
> Alexander Rukletsov wrote:
>     Let's discuss this in the next review https://reviews.apache.org/r/39285/, where
validation is actually implemented.

We will address it in the next review.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review102247
-----------------------------------------------------------


On Nov. 9, 2015, 11:14 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 11:14 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Processing quota request consists of several stages: request validation, sanity check
and so on. This patch creates a basic workflow for quota requests, while the stages are implemented
in subsequent patches.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f6ae05d4652df6de98a9e110efed87f7fcbd29f9 
>   src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota.hpp PRE-CREATION 
>   src/master/quota.cpp PRE-CREATION 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message