mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.
Date Tue, 10 Nov 2015 13:14:51 GMT


> On Oct. 26, 2015, 8:27 a.m., Qian Zhang wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1055-1057
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line1055>
> >
> >     Since we know the guarentee of each quota'ed role and the gap between it and
role's current allocation, I think it might be better to do the "find-grained" allocation,
i.e., only allocate resources to fill the gap. Otherwise, we may run into the situation that
we allocate too much resource to satisfy a role's guarentee but another role's guarentee can
not be satisfied.
> 
> Alexander Rukletsov wrote:
>     Yep, this can be the case and it was a hot debate during the design phase. I have
decided to choose this approach because it's follows the least surprise principle for people
who already familiar with DRF. I think we'll have to revisit the strategy anyway and (most
probably) introduce `Quota.limit`. I think this is fine for MVP.

We also discussed this during the Community Sync on Nov 5th. Coarse-grained is sufficient
for the MVP, and we can look at the fine-grained implications as parth of the next design
doc.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39401/#review103958
-----------------------------------------------------------


On Nov. 9, 2015, 10:01 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39401/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 10:01 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 14fef63714721fcda7cea3c28704766efda6d007

> 
> Diff: https://reviews.apache.org/r/39401/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message