mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39400: Quota: Implemented quota API.
Date Tue, 10 Nov 2015 09:07:51 GMT


> On Oct. 25, 2015, 9:06 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 903
> > <https://reviews.apache.org/r/39400/diff/4/?file=1105059#file1105059line903>
> >
> >     I see that in the code, some are using 
> >     
> >     '" << xxx << "'";
> >     
> >     while some others are using
> >     
> >     \"" << xxx << "\"";
> >     
> >     What is the standard for different style?
> >     
> >     Also when shall we need to add "" for one parameter in log message?
> 
> Alexander Rukletsov wrote:
>     I think we are inconsistent. AFAIK, @neilc is doing some cleanup around.
> 
> Guangya Liu wrote:
>     https://reviews.apache.org/r/39497 has been merged, it is using {{'" << xxx
<< "'";}}, do we need to update this patch accordingly?

That review only sets the precedent for executor ids, which now have a streaming operator
to take care of the formatting.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review103946
-----------------------------------------------------------


On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b

>   src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36

> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message