mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <>
Subject Re: Review Request 37999: Implemented http::AuthenticatorManager
Date Mon, 09 Nov 2015 22:29:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 9, 2015, 11:29 p.m.)

Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.


Changes after Bernd's review.

Bugs: MESOS-3231

Repository: mesos


Introduces the authenticator manager, which is a class which handles the actual authentication
procedure during the execution of `ProcessManager::handle()` and it also takes care of the
life cycle of instances of http::Authenticator.

No tests are added at this point since no public API is generated, the goal of this patch
is to implement the manager and verify nothing breaks afterwards. Authenticator manager tests
proper come in a latter patch.

Diffs (updated)

  3rdparty/libprocess/include/ e6be2c4db121585bbe7f3c0627de048adc7cfb2c 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/event.hpp 16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/include/process/http.hpp 90c9be122ee0c402b806d70fc818e3c03b15101a 
  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 



make check


Alexander Rojas

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message