mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 38956: Quota: Added allocator-agnostic tests.
Date Mon, 09 Nov 2015 13:40:07 GMT


> On Nov. 3, 2015, 7:14 a.m., Guangya Liu wrote:
> > src/tests/master_quota_tests.cpp, line 237
> > <https://reviews.apache.org/r/38956/diff/8/?file=1114104#file1114104line237>
> >
> >     move to upper line?

That's what `clang-format` suggests. Also, I think it's slightly readable this way.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review104880
-----------------------------------------------------------


On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 7:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu,
and Michael Park.
> 
> 
> Bugs: MESOS-3720
>     https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message