mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.
Date Mon, 09 Nov 2015 12:55:34 GMT


> On Nov. 5, 2015, 8:24 p.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, line 52
> > <https://reviews.apache.org/r/38059/diff/13/?file=1116697#file1116697line52>
> >
> >     I feel this shouldn't be left for later.

I think I have to apologize for the confusion I create with this ticket. The implementation
of this function is a stub, it is expanded (and documented) in the next patch by Jörg. The
reason for this is poor job we did in splitting tasks between contributors.


> On Nov. 5, 2015, 8:24 p.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, lines 70-74
> > <https://reviews.apache.org/r/38059/diff/13/?file=1116697#file1116697line70>
> >
> >     These are TODO's right?
> >     
> >     Also, typos:
> >     s/including:/including/
> >     The third "Check" s/Check/check/
> >     s/reservatin/reservation/

Please see above.


> On Nov. 5, 2015, 8:24 p.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, lines 83-88
> > <https://reviews.apache.org/r/38059/diff/13/?file=1116697#file1116697line83>
> >
> >     Why don't you just parse a QuotaInfo object instead of a form-serialized body
(with JSON components)?
> >     
> >     The maintenance endpoints do this for simplicity.

Because we didn't want to expose the internal structure (`QuotaInfo`) to the outside world.
In the future we may want to allow operators to set quotas for multiple roles in one call,
which we can easier do if we do not tie the operator API to `QuotaInfo` protobuf. Does it
make sense?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review105296
-----------------------------------------------------------


On Nov. 5, 2015, 7:28 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 7:28 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Processing quota request consists of several stages: request validation, sanity check
and so on. This patch creates a basic workflow for quota requests, while the stages are implemented
in subsequent patches.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message