mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 39223: Added Quota Request Validation Tests.
Date Sun, 08 Nov 2015 02:24:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/#review105600
-----------------------------------------------------------



src/tests/master_quota_tests.cpp (lines 209 - 210)
<https://reviews.apache.org/r/39223/#comment164223>

    Can you please make this comments limit in 70 per line and ditto for the following?



src/tests/master_quota_tests.cpp (lines 212 - 215)
<https://reviews.apache.org/r/39223/#comment164225>

    indent should be 2 space here?



src/tests/master_quota_tests.cpp (lines 243 - 246)
<https://reviews.apache.org/r/39223/#comment164226>

    2 spaces?



src/tests/master_quota_tests.cpp (lines 274 - 276)
<https://reviews.apache.org/r/39223/#comment164227>

    Keep consistent with above test case request?


- Guangya Liu


On 十一月 6, 2015, 5:02 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39223/
> -----------------------------------------------------------
> 
> (Updated 十一月 6, 2015, 5:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see Summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39223/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message