mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 39840: RegistryClient refactor: pulled up streaming read
Date Fri, 06 Nov 2015 23:49:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/#review105527
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 389)
<https://reviews.apache.org/r/39840/#comment164148>

    I moved this inside of the if(streaming) block since we only need it when streaming is
enabled.


- Timothy Chen


On Nov. 6, 2015, 7:39 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39840/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 7:39 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made reading the stream from the PIPE common.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 29d4d4d6d60ec634efb21b951cf20ff90f6ffed6

> 
> Diff: https://reviews.apache.org/r/39840/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message