mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 39223: Added Quota Request Validation Tests.
Date Fri, 06 Nov 2015 16:07:34 GMT


> On Nov. 3, 2015, 12:35 p.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, line 431
> > <https://reviews.apache.org/r/39223/diff/6/?file=1105362#file1105362line431>
> >
> >     It looks like this comment is a victim of partial refactoring : ). Could you
please udpate it?
> >     
> >     Also we usually use 3rd person in test comments.
> >     
> >     ```
> >     // This test ensures...
> >     ```
> >     or
> >     ```
> >     // This tests that...
> >     ```
> >     or simply
> >     ```
> >     // Tests whether...
> >     ```

Just following your lead on your previous comment ;-): "Verifies that a request for a non-existent
role is rejected."


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/#review104894
-----------------------------------------------------------


On Oct. 23, 2015, 9:10 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39223/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 9:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see Summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39223/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message