mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 37999: Implemented http::AuthenticatorManager
Date Fri, 06 Nov 2015 15:22:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37999/#review105421
-----------------------------------------------------------



3rdparty/libprocess/src/process.cpp (line 533)
<https://reviews.apache.org/r/37999/#comment164011>

    Since we are in a cpp file, we can use "using std::unique_ptr" above and skip the qualifier
"std::" here.



3rdparty/libprocess/src/process.cpp (line 696)
<https://reviews.apache.org/r/37999/#comment164013>

    This seems to be a trick. Are we testing whether we are at "/" here? Ok, so you copied
this code from somewhere else in the same file, but this is too obscure IMHO when written
without any comment.
    
    Please use something more obvious or comment on what this is doing.



3rdparty/libprocess/src/process.cpp (line 750)
<https://reviews.apache.org/r/37999/#comment164028>

    Shouldn't we push the realm as challenge here already?
    
    If we do this below only if all challenges are empty, we are missing the case where challenges
are present some are and some are not.



3rdparty/libprocess/src/process.cpp (line 755)
<https://reviews.apache.org/r/37999/#comment164021>

    s/on/one



3rdparty/libprocess/src/process.cpp (line 756)
<https://reviews.apache.org/r/37999/#comment164024>

    s/was already/has already been
    
    relevance to the present => use present perfect, not imperfect



3rdparty/libprocess/src/process.cpp (line 757)
<https://reviews.apache.org/r/37999/#comment164022>

    s/executed/reached


- Bernd Mathiske


On Nov. 5, 2015, 9:07 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37999/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 9:07 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3231
>     https://issues.apache.org/jira/browse/MESOS-3231
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduces the authenticator manager, which is a class which handles the actual authentication
procedure during the execution of `ProcessManager::handle()` and it also takes care of the
life cycle of instances of http::Authenticator.
> 
> No tests are added at this point since no public API is generated, the goal of this patch
is to implement the manager and verify nothing breaks afterwards. Authenticator manager tests
proper come in a latter patch.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/Makefile.am fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
>   3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/event.hpp 16ddbd77afa6efdf6bad201aa497ee102aa863ae

>   3rdparty/libprocess/include/process/http.hpp 90c9be122ee0c402b806d70fc818e3c03b15101a

>   3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
> 
> Diff: https://reviews.apache.org/r/37999/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message