mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 39285: Added Quota Request Validation.
Date Fri, 06 Nov 2015 15:14:15 GMT


> On Oct. 25, 2015, 2:45 a.m., Klaus Ma wrote:
> > src/master/quota_handler.cpp, line 115
> > <https://reviews.apache.org/r/39285/diff/6/?file=1105159#file1105159line115>
> >
> >     It said the role maybe not set in allocator interface's comments (`setQuota`);
so any case that the role passed validation in master but it's  still empty to allocator?

If I picked the correct comment ("n allocator implementation may assume quota for the given
role is not set prior to the call and react accordingly if this assumption is violated (i.e.
fail)").
This comment refers to whether a role must be exixting prior to the call, this check is concerned
whether the request has a role set which currently is required.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103918
-----------------------------------------------------------


On Oct. 24, 2015, 7:42 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2015, 7:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message