mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.
Date Thu, 05 Nov 2015 20:24:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review105296
-----------------------------------------------------------



src/master/quota_handler.cpp (line 52)
<https://reviews.apache.org/r/38059/#comment163813>

    I feel this shouldn't be left for later.



src/master/quota_handler.cpp (lines 70 - 74)
<https://reviews.apache.org/r/38059/#comment163809>

    These are TODO's right?
    
    Also, typos:
    s/including:/including/
    The third "Check" s/Check/check/
    s/reservatin/reservation/



src/master/quota_handler.cpp (lines 83 - 88)
<https://reviews.apache.org/r/38059/#comment163810>

    Why don't you just parse a QuotaInfo object instead of a form-serialized body (with JSON
components)?
    
    The maintenance endpoints do this for simplicity.



src/master/quota_handler.cpp (line 118)
<https://reviews.apache.org/r/38059/#comment163812>

    Typo: s/reuqest/request/


- Joseph Wu


On Nov. 5, 2015, 11:28 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Processing quota request consists of several stages: request validation, sanity check
and so on. This patch creates a basic workflow for quota requests, while the stages are implemented
in subsequent patches.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message