mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 39017: RegistryClient refactor: changed Manifest struct
Date Thu, 05 Nov 2015 19:15:25 GMT


> On Nov. 5, 2015, 6:35 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line 486
> > <https://reviews.apache.org/r/39017/diff/6/?file=1116786#file1116786line486>
> >
> >     You need to check for errors in all the find JSON calls.

Dropping as this is irrelevant after the protobuf conversion of these jsons.(after discussing
with Tim)


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/#review105285
-----------------------------------------------------------


On Nov. 5, 2015, 4:02 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39017/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added factory method.
>  Removed digest.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359

>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c

> 
> Diff: https://reviews.apache.org/r/39017/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message