mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.
Date Wed, 04 Nov 2015 23:02:56 GMT


> On Nov. 3, 2015, 2:53 p.m., Kapil Arya wrote:
> > src/common/http.cpp, lines 165-189
> > <https://reviews.apache.org/r/39531/diff/7/?file=1105326#file1105326line165>
> >
> >     Actually, my previous comment wasn't quite clear. We can use `JSON::Protobuf`
for NetworkInfo::IPAddress, but not for the entire NetworkInfo since the labels will show
up poorly.

I fixed it and committed the patch.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review104962
-----------------------------------------------------------


On Oct. 23, 2015, 3:21 p.m., Connor Doyle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 3:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
>     https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message allows
framework authors to communicate with network isolation modules via a first-class message
type to request IP addresses and network group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors and module
implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the container.
> 2) It's difficult for application developers to understand the final policy when multiple
IP addresses can be assigned with differing isolation policies.
> 
> 
> Diffs
> -----
> 
>   docs/networking-for-mesos-managed-containers.md 33568a8 
>   include/mesos/mesos.proto 9400434 
>   include/mesos/v1/mesos.proto 8131778 
>   src/common/http.hpp 0cc98a8 
>   src/common/http.cpp f56d8a1 
>   src/docker/executor.cpp 1e49013 
>   src/examples/test_hook_module.cpp 43d6cb9 
>   src/slave/slave.cpp e9f2d1b 
>   src/tests/common/http_tests.cpp c2e7704 
>   src/tests/hook_tests.cpp 5a5d019 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message