mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 39914: Changed verify_review to use docker_build.sh.
Date Wed, 04 Nov 2015 21:19:55 GMT


> On Nov. 4, 2015, 9:12 p.m., Vinod Kone wrote:
> > support/verify_reviews.py, line 122
> > <https://reviews.apache.org/r/39914/diff/2/?file=1115942#file1115942line122>
> >
> >     have you verified this change locally?
> >     
> >     the docker_build.sh script expects certain environment variables to be set.

I ran the script locally by setting the OS, CONFIGURATION etc manually. I didnt know the workflow
for setting these. How are these env variables set?


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review105136
-----------------------------------------------------------


On Nov. 4, 2015, 8:47 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 8:47 p.m.)
> 
> 
> Review request for mesos, Cody Maloney and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> SSL based tests are not currently verified on reviewbot. This change would make reviewbot
environment to be same as mesos builds on jenkins.
> 
> 
> Diffs
> -----
> 
>   support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 
> 
> Diff: https://reviews.apache.org/r/39914/diff/
> 
> 
> Testing
> -------
> 
> ran script locally
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message