mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 39944: Add prefix option for os::environment.
Date Wed, 04 Nov 2015 18:17:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39944/#review105109
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp (line 40)
<https://reviews.apache.org/r/39944/#comment163514>

    I thought the intent here was to check for prefix and not anywhere in the string.


- Jojy Varghese


On Nov. 4, 2015, 6:02 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39944/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 6:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3815
>     https://issues.apache.org/jira/browse/MESOS-3815
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add prefix option for os::environment.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp 91d82a8fae27c002458cad0bbdc45b312d2ec70d

> 
> Diff: https://reviews.apache.org/r/39944/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message