mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.
Date Wed, 04 Nov 2015 14:13:59 GMT


> On Oct. 25, 2015, 5:46 a.m., Qian Zhang wrote:
> > include/mesos/master/allocator.hpp, line 357
> > <https://reviews.apache.org/r/38218/diff/7/?file=1105051#file1105051line357>
> >
> >     Why do we assume quota for the given role is not set prior to the call? I thought
we support setting quota for a role many time, i.e., the subsequent call will overwrite the
quota set by the previous call, right?
> 
> Alexander Rukletsov wrote:
>     Nope. "Overwriting" or updating quota is not straightforward and will be done in
the next iterations, which means there will be introduced an `updateQuota()` method.

IMHO having a setQuota call that assumes no prior quota is superfluous once we have implemented
updateQuota, which will be able to deal with any situation. But it is OK for this first interation
to get there. Let's revisit this later.


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review103953
-----------------------------------------------------------


On Oct. 23, 2015, 9:38 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 9:38 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3716
>     https://issues.apache.org/jira/browse/MESOS-3716
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
>   src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5 
>   src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b

>   src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36

>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
> 
> Diff: https://reviews.apache.org/r/38218/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message