mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 36071: Add flow diagram for docker containerizer.
Date Wed, 04 Nov 2015 11:32:02 GMT


> On July 7, 2015, 4:51 a.m., Bernd Mathiske wrote:
> > 1. Inconsistent capitalization in box labels.
> > 2. You explain different paths to obtain an "executor pid" and then you checkpoint
a "container pid". You lost me there.
> > 3. What happens to the tasks? Is this diagram for the executor only? If so, it is
incomplete.

Is this still being worked on?


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36071/#review90685
-----------------------------------------------------------


On July 6, 2015, 2:37 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36071/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 2:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add flow diagram for docker containerizer.
> 
> 
> Diffs
> -----
> 
>   docs/docker-containerizer.md 73f897780a0bb72ab092cb08186a228e3084e798 
>   docs/images/docker_containerizer_flow.jpg PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36071/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> File Attachments
> ----------------
> 
> docker_containerizer_flow.png
>   https://reviews.apache.org/media/uploaded/files/2015/07/06/d888a674-17d8-4faf-ab03-f1892537a6e5__docker_containerizer_flow.png
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message