mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 39258: Add filesystem isolator with command executor test.
Date Wed, 04 Nov 2015 08:34:19 GMT


> On Nov. 3, 2015, 1:30 a.m., Jie Yu wrote:
> > src/tests/containerizer/filesystem_isolator_tests.cpp, line 286
> > <https://reviews.apache.org/r/39258/diff/3/?file=1114147#file1114147line286>
> >
> >     any reason you use 'copy'. Can we do bind to speed up tests?
> 
> Timothy Chen wrote:
>     it failed when the filesystem isolator tries to mkdir sandbox
> 
> Timothy Chen wrote:
>     i think alternatifely i can also let Rootfs clasd create a sandbox mount point too

I tried to use BindBackend, but it then failed to create mount point for the old root in the
/tmp directory of the new root in fs.cpp as Bind simply made the whole filesystem read-only.
I think I'll use Copy for now.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review104842
-----------------------------------------------------------


On Nov. 2, 2015, 7:05 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39258/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 7:05 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add filesystem isolator with command executor test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b

>   src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef 
> 
> Diff: https://reviews.apache.org/r/39258/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message