mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.
Date Wed, 04 Nov 2015 07:14:11 GMT


> On Nov. 2, 2015, 8:19 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 605
> > <https://reviews.apache.org/r/39866/diff/1/?file=1114138#file1114138line605>
> >
> >     Wondering if this means that we can use ContainerInfo as a predicate for "launch"
inside the "composing" containerizer? Today we call "launch" on the containerizer(docker or
mesos) and let the "luanch" decide if it can handle the task. Now that we have the information
right away at the composing containerizer, maybe we can use that?
> 
> Timothy Chen wrote:
>     we cant since we cant distinguish between mesos containerizer and external containerizer
> 
> Jojy Varghese wrote:
>     Ah. i thought external containerizer is to be discontinued.

Not yet though :)


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39866/#review104782
-----------------------------------------------------------


On Nov. 2, 2015, 6:59 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39866/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 6:59 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added containerInfo support for tasks in mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 4aad8a3be43b331efc6b8157b2fae090df16c1b4

>   src/slave/containerizer/mesos/containerizer.cpp 9fd69c1738e2300dbb843d259727010e24523cff

> 
> Diff: https://reviews.apache.org/r/39866/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message