mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Peach" <jpe...@apache.org>
Subject Re: Review Request 39771: Show the failing path when execvpe(2) fails.
Date Wed, 04 Nov 2015 00:20:56 GMT


> On Nov. 3, 2015, 10:45 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 179-180
> > <https://reviews.apache.org/r/39771/diff/1/?file=1112445#file1112445line179>
> >
> >     Technically we should not be appending strings like this since malloc is not
async-signal-safe. But since you're not introducing the issue, it's alright.
> >     
> >     (1) Typically we would print like this: "Failed to os::execvpe on path '<path>':
<reason>".
> >     
> >     (2) Mind fixing the indent on your second line?

I could make _Abort() take a nul-terminated varargs list of string constants. That would get
rid of the allocation :)


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39771/#review104994
-----------------------------------------------------------


On Oct. 29, 2015, 9 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39771/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 9 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3608
>     https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Show the failing path when execvpe(2) fails.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp 459825c188d56d25f6e2832e5a170d806e257d6b 
> 
> Diff: https://reviews.apache.org/r/39771/diff/
> 
> 
> Testing
> -------
> 
> make check and manual testing.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message