mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 39005: stout: Added thread-safe replacement for strerror.
Date Tue, 03 Nov 2015 22:57:33 GMT


> On Nov. 2, 2015, 7:13 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, lines 1045-1076
> > <https://reviews.apache.org/r/39005/diff/5/?file=1103895#file1103895line1045>
> >
> >     Can we please move this to its own tests file so that we can run it on Windows
too? `os_test.cpp` has is too big and full of unimplemented stuff to add Windows support right
now.

Yes, that is a good suggestion. I moved these to an extra file so they can be tested in isolation.
Note that the test can only be registered with a commit to libprocess since it owns the build
files for even stout tests. I also added the new file to the `CMakeLists.txt`).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/#review104760
-----------------------------------------------------------


On Nov. 3, 2015, 10:52 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39005/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 10:52 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit also adds test cases for os::strerror (from stout) which can
> only be committed with a libprocess commit -- the corresponding Makefile
> lives there.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 76e1674e08bbe65a4fdf86731823a61f231d6d12

>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 67b142bbc2d80f40a1e893cc5813d58dd2aa8381

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 26e1377ee625748b7fdbec327fef9ac602535f83

>   3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39005/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message