mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds
Date Tue, 03 Nov 2015 22:40:30 GMT


> On Nov. 3, 2015, 8:10 p.m., Vinod Kone wrote:
> > would this only test libevent and skip libev? if yes, we can't do this.
> 
> Jojy Varghese wrote:
>     Would it help to add libev also? I was trying to make this look like the jenkins
mesos builds. Console logs there show :
>     ``` echo CMD ./bootstrap '&&' ./configure --verbose --enable-libevent --enable-ssl
&& ...```
> 
> Vinod Kone wrote:
>     the jenkins "mesos" build is a parameterized build, where one of the parameters is
the configuration options. the config options we test are
>     "--enable-libevent --enable-ssl" and "" (empty string which tests libev).
>     
>     unfortunately, the review bot doesn't support these parameters yet. review bot doesn't
even run inside docker like the "mesos" build. so it just tests one platform (ubuntu) and
the default parameters. it would be great if we can fix the review bot to do the same things
as "mesos". feel free to create a ticket. i'll be happy to shepherd.

Just created https://issues.apache.org/jira/browse/MESOS-3825. Since there is only 1 platform,
do we need to parameterize ? Can we just assume a fixed configuration ? Or add the required
packages to the machine/VM and always use --enable-ssl and --enable-libevent ?


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review104969
-----------------------------------------------------------


On Nov. 3, 2015, 7:42 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 7:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Cody Maloney.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> SSL based tests are not currently verified on reviewbot. This change should enable those
tests to be run.
> 
> 
> Diffs
> -----
> 
>   support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 
> 
> Diff: https://reviews.apache.org/r/39914/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message