mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds
Date Tue, 03 Nov 2015 20:06:56 GMT


> On Nov. 3, 2015, 7:46 p.m., Joseph Wu wrote:
> > Are openssl and libevent present on the reviewbot machine?  
> > (And does reviewbot use the modified version of `verify_reviews.py` when checking
this one?)

Not sure. I would think that the installation of dependencies exists outside the scoep of
this file. Maybe dockerfile?


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review104960
-----------------------------------------------------------


On Nov. 3, 2015, 7:42 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 7:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Cody Maloney.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> SSL based tests are not currently verified on reviewbot. This change should enable those
tests to be run.
> 
> 
> Diffs
> -----
> 
>   support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 
> 
> Diff: https://reviews.apache.org/r/39914/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message