mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39223: Added Quota Request Validation Tests.
Date Tue, 03 Nov 2015 12:38:56 GMT


> On Oct. 25, 2015, 8:31 a.m., Guangya Liu wrote:
> > src/tests/master_quota_tests.cpp, line 564
> > <https://reviews.apache.org/r/39223/diff/6/?file=1105362#file1105362line564>
> >
> >     We should unify if use "role1" or role1 for all of the tests

I vote for variables, since they were introduced exactly for this.


> On Oct. 25, 2015, 8:31 a.m., Guangya Liu wrote:
> > src/tests/master_quota_tests.cpp, line 433
> > <https://reviews.apache.org/r/39223/diff/6/?file=1105362#file1105362line433>
> >
> >     s/Set_InvalidRequest/SetInvalidRequest?
> >     
> >     Ditto for the following

I think the intention was to indicate these tests relate to quota set requests. However, I'm
+1 for removing the underscore, because it violates the consistency.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/#review103945
-----------------------------------------------------------


On Oct. 23, 2015, 9:10 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39223/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 9:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see Summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39223/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message