mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.
Date Sun, 01 Nov 2015 23:32:18 GMT


> On 十月 25, 2015, 1:39 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1035
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line1035>
> >
> >     I know that we have design to exclue the reserved resource from quota, but why
not include the current role's reserved as available?
> 
> Alexander Rukletsov wrote:
>     If you mean dynamically reserved resources than yes, we can do that. If you mean
statically reserved than nope, we decided not to conflate them with quota.

I mean both static and dynamic reservation, I think that both of the reservations for one
role should be included in the role's quota, can you pleaes clairify why not include static
reservation in one role's quota?


> On 十月 25, 2015, 1:39 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1058
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line1058>
> >
> >     Where does those offerable resource offered to master?
> 
> Alexander Rukletsov wrote:
>     https://github.com/apache/mesos/blob/master/src/master/allocator/mesos/hierarchical.cpp#L956
>     
>     Dropping the issue, feel free to reopen if I haven't answered your question.

I did not see that those resources are offered to master via the offer callback, but I see
that you already updated code diff to resolve this. ;-)


> On 十月 25, 2015, 1:39 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 982
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line982>
> >
> >     s/unsatisfiedRoleQuotas/unAllocatedRoleQuotas?
> 
> Alexander Rukletsov wrote:
>     Dynamic reservations may not be allocated, but should still count towards quota.

But this is actually not allocated role quota, can we use a more meaningful name? The name
of `unsatisfiedRoleQuotas` is more likely to be the value that the role quota needed to fill
in its quota guarantee value. Comments?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39401/#review103954
-----------------------------------------------------------


On 十月 29, 2015, 7:29 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39401/
> -----------------------------------------------------------
> 
> (Updated 十月 29, 2015, 7:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36

> 
> Diff: https://reviews.apache.org/r/39401/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message