From reviews-return-13262-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Oct 26 22:54:36 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 517A218AE6 for ; Mon, 26 Oct 2015 22:54:36 +0000 (UTC) Received: (qmail 4760 invoked by uid 500); 26 Oct 2015 22:45:33 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 4755 invoked by uid 500); 26 Oct 2015 22:45:33 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 4744 invoked by uid 99); 26 Oct 2015 22:45:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Oct 2015 22:45:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CEFC928E1CA; Mon, 26 Oct 2015 22:45:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3657856176524128394==" MIME-Version: 1.0 Subject: Re: Review Request 39497: Fixed quotation of interpolated variables in log messages. From: "Joris Van Remoortere" To: "Joris Van Remoortere" Cc: "Neil Conway" , "mesos" Date: Mon, 26 Oct 2015 22:45:32 -0000 Message-ID: <20151026224532.22462.8097@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joris Van Remoortere" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39497/ X-Sender: "Joris Van Remoortere" References: <20151021023734.1666.96597@reviews.apache.org> In-Reply-To: <20151021023734.1666.96597@reviews.apache.org> Reply-To: "Joris Van Remoortere" X-ReviewRequest-Repository: mesos --===============3657856176524128394== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/#review104101 ----------------------------------------------------------- Ship it! minus the removal of taskid quotations. - Joris Van Remoortere On Oct. 21, 2015, 2:37 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39497/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 2:37 a.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-3772 > https://issues.apache.org/jira/browse/MESOS-3772 > > > Repository: mesos > > > Description > ------- > > Specifically, we should always quote executor IDs (because they are > user-supplied and might contain whitespace), but we don't need to quote > framework IDs. There's a bunch more work we could do here (e.g., escaping > punctuation), but this is a start. > > Also fix a few style issues with usage of "<<" operators. > > > Diffs > ----- > > src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4 > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa > src/slave/containerizer/isolators/network/port_mapping.cpp e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef > src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 > src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab > src/tests/containerizer.cpp 451c7be0bfd668ccd3325964cafcc4cbac941a94 > > Diff: https://reviews.apache.org/r/39497/diff/ > > > Testing > ------- > > make check, visual inspection. > > > Thanks, > > Neil Conway > > --===============3657856176524128394==--