From reviews-return-13191-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Oct 24 23:30:54 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0E9CD10B53 for ; Sat, 24 Oct 2015 23:30:54 +0000 (UTC) Received: (qmail 91503 invoked by uid 500); 24 Oct 2015 23:30:54 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 91479 invoked by uid 500); 24 Oct 2015 23:30:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 91462 invoked by uid 99); 24 Oct 2015 23:30:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Oct 2015 23:30:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5E773279FCC; Sat, 24 Oct 2015 23:30:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7734680647959973015==" MIME-Version: 1.0 Subject: Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically From: "Klaus Ma" To: "Niklas Nielsen" , "Till Toenshoff" , "Adam B" , "Bernd Mathiske" Cc: "Klaus Ma" , "mesos" , "Alexander Rojas" Date: Sat, 24 Oct 2015 23:30:53 -0000 Message-ID: <20151024233053.1655.9330@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Klaus Ma" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38627/ X-Sender: "Klaus Ma" References: <20151021125216.1666.38078@reviews.apache.org> In-Reply-To: <20151021125216.1666.38078@reviews.apache.org> Reply-To: "Klaus Ma" X-ReviewRequest-Repository: mesos --===============7734680647959973015== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review103909 ----------------------------------------------------------- Ship it! Ship It! - Klaus Ma On Oct. 21, 2015, 8:52 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38627/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 8:52 p.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-3072 > https://issues.apache.org/jira/browse/MESOS-3072 > > > Repository: mesos > > > Description > ------- > > Allows developers to provide their own parameters when loading modules instead of using the ones provided by the user when loading Mesos. This helps to deal with default modules (those used when the user doesn't provide any), and for testing of the modules. > > > Diffs > ----- > > src/examples/example_module_impl.cpp db015cea130701a4e0a6fcb890c79fbb0c02c1ce > src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 > src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef > src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 > src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 > > Diff: https://reviews.apache.org/r/38627/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > > --===============7734680647959973015==--