From reviews-return-13040-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Oct 22 23:03:49 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E1EED18C31 for ; Thu, 22 Oct 2015 23:03:48 +0000 (UTC) Received: (qmail 87188 invoked by uid 500); 22 Oct 2015 23:03:48 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 87163 invoked by uid 500); 22 Oct 2015 23:03:48 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 87141 invoked by uid 99); 22 Oct 2015 23:03:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Oct 2015 23:03:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 15C792789D5; Thu, 22 Oct 2015 23:03:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2831663624145497642==" MIME-Version: 1.0 Subject: Re: Review Request 39385: Fixed link conversion regexp in website. From: "Neil Conway" To: "Adam B" , "Dave Lester" Cc: "Neil Conway" , "Mesos ReviewBot" , "mesos" Date: Thu, 22 Oct 2015 23:03:48 -0000 Message-ID: <20151022230348.1667.86710@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Neil Conway" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39385/ X-Sender: "Neil Conway" References: <20151016044203.28636.50711@reviews.apache.org> In-Reply-To: <20151016044203.28636.50711@reviews.apache.org> Reply-To: "Neil Conway" X-ReviewRequest-Repository: mesos --===============2831663624145497642== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39385/ ----------------------------------------------------------- (Updated Oct. 22, 2015, 11:03 p.m.) Review request for mesos, Adam B and Dave Lester. Changes ------- More testing. Repository: mesos Description ------- The previous regexp was: /\((.*)(\.md)\)/ Given text like: Text (comment): [link](foo.md) This will greedily match ".*", so \1 is bound to "comment): [link](foo", which seems unlikely to be the desired result. Diffs (updated) ----- site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c Diff: https://reviews.apache.org/r/39385/diff/ Testing (updated) ------- Tested using support/site-docker -- a few places where the old regexp screwed up were corrected, otherwise no changes observed. Thanks, Neil Conway --===============2831663624145497642==--