From reviews-return-12921-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Oct 21 18:07:25 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E149C18C91 for ; Wed, 21 Oct 2015 18:07:25 +0000 (UTC) Received: (qmail 81128 invoked by uid 500); 21 Oct 2015 18:07:25 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 81102 invoked by uid 500); 21 Oct 2015 18:07:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 81089 invoked by uid 99); 21 Oct 2015 18:07:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Oct 2015 18:07:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1D66B278288; Wed, 21 Oct 2015 18:07:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2994245161862878846==" MIME-Version: 1.0 Subject: Re: Review Request 39514: HTTP Scheduler API no longer allows FrameworkInfo.user to be empty From: "Marco Massenzio" To: "mesos" , "Liqiang Lin" , "Marco Massenzio" Date: Wed, 21 Oct 2015 18:07:25 -0000 Message-ID: <20151021180725.1667.70854@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Marco Massenzio" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39514/ X-Sender: "Marco Massenzio" References: <20151021180539.1667.66532@reviews.apache.org> In-Reply-To: <20151021180539.1667.66532@reviews.apache.org> Reply-To: "Marco Massenzio" X-ReviewRequest-Repository: mesos --===============2994245161862878846== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 21, 2015, 6:05 p.m., Marco Massenzio wrote: > > include/mesos/v1/mesos.proto, lines 211-213 > > > > > > I know it's not your code, but could you please remove `automagically` (there's nothing magic in a string assignment :) > > > > Please use: `SchedulerDriver` > > > > The comment could read more easily if you changed it to: > > ``` > > // When the Scheduler HTTP API is used for registering the framework, > > // the `user` field should be explicitly set, unless the > > // `--switch_user` flag is explicitly set to `false` on > > // the agent nodes (otherwise, the tasks will fail). > > // For the same reason, if the user is set, it should be an > > // existing user on the agent nodes, with the necessary permissions. bad formatting, apologies: ``` // When the Scheduler HTTP API is used for registering the framework, // the `user` field should be explicitly set, unless the // `--switch_user` flag is explicitly set to `false` on // the agent nodes (otherwise, the tasks will fail). // For the same reason, if the user is set, it should be an // existing user on the agent nodes, with the necessary permissions. ``` - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39514/#review103440 ----------------------------------------------------------- On Oct. 21, 2015, 8:48 a.m., Liqiang Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39514/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 8:48 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-3747 > https://issues.apache.org/jira/browse/MESOS-3747 > > > Repository: mesos > > > Description > ------- > > Add validation to check whether FrameworkInfo.user be empty. Fail > framework action if framework user is empty. > > > Diffs > ----- > > include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a > src/master/validation.cpp 9c7c8c123c5bd13b99a2c1c7318515d687b4bc34 > > Diff: https://reviews.apache.org/r/39514/diff/ > > > Testing > ------- > > make check done. > > > Thanks, > > Liqiang Lin > > --===============2994245161862878846==--