From reviews-return-12901-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Oct 21 15:24:32 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D52F0184C1 for ; Wed, 21 Oct 2015 15:24:32 +0000 (UTC) Received: (qmail 81473 invoked by uid 500); 21 Oct 2015 15:24:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 81449 invoked by uid 500); 21 Oct 2015 15:24:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 81435 invoked by uid 99); 21 Oct 2015 15:24:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Oct 2015 15:24:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C21FA27860D; Wed, 21 Oct 2015 15:24:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0610841773068484407==" MIME-Version: 1.0 Subject: Re: Review Request 39516: Slave should accept PingSlaveMessage but not "PING" message. From: "Neil Conway" To: "Vinod Kone" Cc: "Neil Conway" , "Yong Qiao Wang" , "mesos" Date: Wed, 21 Oct 2015 15:24:22 -0000 Message-ID: <20151021152422.1667.88250@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Neil Conway" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39516/ X-Sender: "Neil Conway" References: <20151021131956.1666.61674@reviews.apache.org> In-Reply-To: <20151021131956.1666.61674@reviews.apache.org> Reply-To: "Neil Conway" X-ReviewRequest-Repository: mesos --===============0610841773068484407== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39516/#review103411 ----------------------------------------------------------- src/slave/slave.hpp (line 186) Is this comment still relevant? - Neil Conway On Oct. 21, 2015, 1:19 p.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39516/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 1:19 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1832 > https://issues.apache.org/jira/browse/MESOS-1832 > > > Repository: mesos > > > Description > ------- > > Slave should accept PingSlaveMessage but not "PING" message. > > > Diffs > ----- > > src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa > src/slave/slave.hpp 04a8646bce53adaaeb6e06ea65bb82e1f1da91e0 > src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 > > Diff: https://reviews.apache.org/r/39516/diff/ > > > Testing > ------- > > Make Successfully; > Make check Successfully; > > > Thanks, > > Yong Qiao Wang > > --===============0610841773068484407==--