From reviews-return-12789-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Oct 20 19:47:17 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E59361733E for ; Tue, 20 Oct 2015 19:47:16 +0000 (UTC) Received: (qmail 14083 invoked by uid 500); 20 Oct 2015 19:46:42 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 14062 invoked by uid 500); 20 Oct 2015 19:46:42 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 14047 invoked by uid 99); 20 Oct 2015 19:46:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Oct 2015 19:46:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 387CF2781F1; Tue, 20 Oct 2015 19:46:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3223710451509505505==" MIME-Version: 1.0 Subject: Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`. From: "Joris Van Remoortere" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Joseph Wu" Cc: "Alex Clemmer" , "mesos" Date: Tue, 20 Oct 2015 19:46:42 -0000 Message-ID: <20151020194642.1666.91591@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joris Van Remoortere" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39378/ X-Sender: "Joris Van Remoortere" References: <20151019233116.32264.27252@reviews.apache.org> In-Reply-To: <20151019233116.32264.27252@reviews.apache.org> Reply-To: "Joris Van Remoortere" X-ReviewRequest-Repository: mesos --===============3223710451509505505== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39378/#review103279 ----------------------------------------------------------- Ship it! - Joris Van Remoortere On Oct. 19, 2015, 11:31 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39378/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 11:31 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. > > > Bugs: MESOS-3649 and MESOS-3680 > https://issues.apache.org/jira/browse/MESOS-3649 > https://issues.apache.org/jira/browse/MESOS-3680 > > > Repository: mesos > > > Description > ------- > > Windows: Added support for `process/subprocess.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp d2341a53aac7c779668ee80983f73158fd44bff5 > > Diff: https://reviews.apache.org/r/39378/diff/ > > > Testing > ------- > > CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10. > > Autotools `make check` on Ubuntu 15. > > > Thanks, > > Alex Clemmer > > --===============3223710451509505505==--