From reviews-return-12757-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Oct 20 10:30:31 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE3D4108D9 for ; Tue, 20 Oct 2015 10:30:31 +0000 (UTC) Received: (qmail 92899 invoked by uid 500); 20 Oct 2015 10:30:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 92880 invoked by uid 500); 20 Oct 2015 10:30:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 92864 invoked by uid 99); 20 Oct 2015 10:30:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Oct 2015 10:30:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 344DE27819F; Tue, 20 Oct 2015 10:30:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0736906765528438142==" MIME-Version: 1.0 Subject: Re: Review Request 39043: Added support for HTTP Authentication in Mesos. From: "Alexander Rojas" To: "Isabel Jimenez" , "Adam B" , "Bernd Mathiske" , "Till Toenshoff" Cc: "mesos" , "Alexander Rojas" , "Mesos ReviewBot" Date: Tue, 20 Oct 2015 10:30:31 -0000 Message-ID: <20151020103031.1666.63579@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Rojas" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39043/ X-Sender: "Alexander Rojas" References: <20151006145653.31883.28535@reviews.apache.org> In-Reply-To: <20151006145653.31883.28535@reviews.apache.org> Reply-To: "Alexander Rojas" X-ReviewRequest-Repository: mesos --===============0736906765528438142== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ ----------------------------------------------------------- (Updated Oct. 20, 2015, 12:30 p.m.) Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till Toenshoff. Changes ------- Rebase. Updated JIRA entry. Bugs: MESOS-3756 https://issues.apache.org/jira/browse/MESOS-3756 Repository: mesos Description ------- 1. Adds a flag to load an HTTP Authenticator module from the flags. 2. If provided, uses the credentials file to initialize the default HTTP Authenticator. 3. Updates the existing endpoints which implement their own basic HTTP authenticator with the libprocess one. 4. Updates one test which expected the wrong results since now credentials are checked before the body of the request. Diffs (updated) ----- src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa Diff: https://reviews.apache.org/r/39043/diff/ Testing ------- make check Thanks, Alexander Rojas --===============0736906765528438142==--