From reviews-return-12674-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Oct 19 22:10:53 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F073518D4F for ; Mon, 19 Oct 2015 22:10:52 +0000 (UTC) Received: (qmail 32996 invoked by uid 500); 19 Oct 2015 22:09:54 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 32976 invoked by uid 500); 19 Oct 2015 22:09:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 32892 invoked by uid 99); 19 Oct 2015 22:09:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Oct 2015 22:09:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DF55827784C; Mon, 19 Oct 2015 22:09:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1757944873484889675==" MIME-Version: 1.0 Subject: Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag From: "Michael Park" To: "Ben Mahler" Cc: "Michael Park" , "Marco Massenzio" , "mesos" Date: Mon, 19 Oct 2015 22:09:51 -0000 Message-ID: <20151019220951.32263.21669@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Michael Park" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39447/ X-Sender: "Michael Park" References: <20151019212731.32264.21925@reviews.apache.org> In-Reply-To: <20151019212731.32264.21925@reviews.apache.org> Reply-To: "Michael Park" X-ReviewRequest-Repository: mesos --===============1757944873484889675== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103170 ----------------------------------------------------------- docs/configuration.md (line 1442) How about `s/submitted/launched/`? docs/configuration.md (line 1445) `\Could not chown work directory\` -- is this intentional? If yes, what does it do...? docs/configuration.md (line 1448) `s/Agent/agent/` src/slave/paths.cpp (line 427) `s/non existing/nonexistent/` `s/Agent/agent/` src/slave/paths.cpp (line 428) Wrap `--switch_user` in ``` - Michael Park On Oct. 19, 2015, 9:27 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39447/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 9:27 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3692 > https://issues.apache.org/jira/browse/MESOS-3692 > > > Repository: mesos > > > Description > ------- > > MESOS-3692 - better documented --switch_user flag > Added better logging around the point where the error may occur. > > > Diffs > ----- > > docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 > src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 > src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 > > Diff: https://reviews.apache.org/r/39447/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > > --===============1757944873484889675==--