From reviews-return-12517-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Oct 16 23:03:42 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7911E18F74 for ; Fri, 16 Oct 2015 23:03:42 +0000 (UTC) Received: (qmail 65597 invoked by uid 500); 16 Oct 2015 23:03:42 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 65569 invoked by uid 500); 16 Oct 2015 23:03:42 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 65550 invoked by uid 99); 16 Oct 2015 23:03:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Oct 2015 23:03:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2B1B12A4153; Fri, 16 Oct 2015 23:03:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2487138073409226147==" MIME-Version: 1.0 Subject: Re: Review Request 37336: Simplified the caller interface to process::Subprocess From: "Marco Massenzio" To: "Joris Van Remoortere" , "Michael Park" Cc: "Marco Massenzio" , "mesos" , "Ben Mahler" , "Mesos ReviewBot" Date: Fri, 16 Oct 2015 23:03:40 -0000 Message-ID: <20151016230340.28636.9068@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Marco Massenzio" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37336/ X-Sender: "Marco Massenzio" References: <20151012122936.28635.94240@reviews.apache.org> In-Reply-To: <20151012122936.28635.94240@reviews.apache.org> Reply-To: "Marco Massenzio" X-ReviewRequest-Repository: mesos --===============2487138073409226147== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ ----------------------------------------------------------- (Updated Oct. 16, 2015, 11:03 p.m.) Review request for mesos, Joris Van Remoortere and Michael Park. Bugs: MESOS-3035 https://issues.apache.org/jira/browse/MESOS-3035 Repository: mesos Description (updated) ------- Jira: MESOS-3035 The original API for `process::Subprocess` still left a lot of legwork to do for the caller; we have now added an `executed()` method that returns a `Future` (also introduced with this patch) which contains useful information about the command invocation; the exit code; stdout and, optionally, stderr too. Once the Future completes, if successful, the caller will be able to retrieve stdout/stderr; whether the command was successful; and whether it received a signal Diffs ----- 3rdparty/libprocess/include/process/subprocess.hpp d2341a53aac7c779668ee80983f73158fd44bff5 3rdparty/libprocess/src/subprocess.cpp d6ea62ed1c914d34e0e189395831c86fff8aac22 3rdparty/libprocess/src/tests/subprocess_tests.cpp ab7515325e5db0a4fd222bb982f51243d7b7e39d Diff: https://reviews.apache.org/r/37336/diff/ Testing ------- make check Thanks, Marco Massenzio --===============2487138073409226147==--