From reviews-return-12438-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org  Fri Oct 16 09:26:23 2015
Return-Path: <reviews-return-12438-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5EE4410925
	for <apmail-mesos-reviews-archive@minotaur.apache.org>; Fri, 16 Oct 2015 09:26:23 +0000 (UTC)
Received: (qmail 65458 invoked by uid 500); 16 Oct 2015 09:26:23 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 65435 invoked by uid 500); 16 Oct 2015 09:26:23 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 65419 invoked by uid 99); 16 Oct 2015 09:26:22 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Oct 2015 09:26:22 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 1F9B21D2251;
	Fri, 16 Oct 2015 09:26:21 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============2358144263731365849=="
MIME-Version: 1.0
Subject: Re: Review Request 39385: Fixed link conversion regexp in website.
From: "Mesos ReviewBot" <reviews@mesos.apache.org>
To: "Dave Lester" <dlester@apache.org>
Cc: "Neil Conway" <neil.conway@gmail.com>,
 "Mesos ReviewBot" <reviews@mesos.apache.org>,
 "mesos" <reviews@mesos.apache.org>
Date: Fri, 16 Oct 2015 09:26:21 -0000
Message-ID: <20151016092621.1509.31184@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/39385/
X-Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
References: <20151016044203.28636.50711@reviews.apache.org>
In-Reply-To: <20151016044203.28636.50711@reviews.apache.org>
Reply-To: "Mesos ReviewBot" <reviews@mesos.apache.org>
X-ReviewRequest-Repository: mesos

--===============2358144263731365849==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/#review102895
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39385]

All tests passed.

- Mesos ReviewBot


On Oct. 16, 2015, 4:42 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39385/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 4:42 a.m.)
> 
> 
> Review request for mesos and Dave Lester.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The previous regexp was:
> 
>     /\((.*)(\.md)\)/
> 
> Given text like:
> 
>     Text (comment): [link](foo.md)
> 
> This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
> seems unlikely to be the desired result.
> 
> 
> Diffs
> -----
> 
>   site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c 
> 
> Diff: https://reviews.apache.org/r/39385/diff/
> 
> 
> Testing
> -------
> 
> Tested using "http://rubular.com/" -- didn't actually test on mesos-website-container, since it doesn't use the site code from Git just yet.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


--===============2358144263731365849==--