From reviews-return-12299-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Oct 14 21:25:57 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89C6D18AC5 for ; Wed, 14 Oct 2015 21:25:57 +0000 (UTC) Received: (qmail 72524 invoked by uid 500); 14 Oct 2015 21:25:54 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 72501 invoked by uid 500); 14 Oct 2015 21:25:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 72485 invoked by uid 99); 14 Oct 2015 21:25:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Oct 2015 21:25:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8D5072A2BA8; Wed, 14 Oct 2015 21:25:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1897796278744870388==" MIME-Version: 1.0 Subject: Re: Review Request 39324: Updated protobuf::parse to handle JSON "null" values. From: "Mesos ReviewBot" To: "Ben Mahler" , "Jie Yu" Cc: "Mesos ReviewBot" , "Kapil Arya" , "mesos" Date: Wed, 14 Oct 2015 21:25:52 -0000 Message-ID: <20151014212552.1509.74200@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39324/ X-Sender: "Mesos ReviewBot" References: <20151014183151.28636.11437@reviews.apache.org> In-Reply-To: <20151014183151.28636.11437@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============1897796278744870388== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39324/#review102707 ----------------------------------------------------------- Patch looks great! Reviews applied: [39324] All tests passed. - Mesos ReviewBot On Oct. 14, 2015, 6:31 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39324/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 6:31 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This allows us to handle JSON objects that have some fields set to "null". > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 2285ce9eaba668d5215c108849055fe92163da4d > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2d9bb61cb3b832c1136dfe9a77f8421768 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798f06f89f89f412da0490615c8ae03c90b6 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d04822ad043a3f5aebe531b34c0a9809155 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c98b74513c374dac4673fcb445e30beef61 > > Diff: https://reviews.apache.org/r/39324/diff/ > > > Testing > ------- > > Added a new tests in stout::protobuf_tests and ran make check. > > > Thanks, > > Kapil Arya > > --===============1897796278744870388==--