From reviews-return-11745-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Oct 8 09:53:11 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B33D118BA1 for ; Thu, 8 Oct 2015 09:53:11 +0000 (UTC) Received: (qmail 6889 invoked by uid 500); 8 Oct 2015 09:52:44 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 6865 invoked by uid 500); 8 Oct 2015 09:52:44 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 6844 invoked by uid 99); 8 Oct 2015 09:52:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Oct 2015 09:52:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5D0941D1D3A; Thu, 8 Oct 2015 09:52:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2200439559662741620==" MIME-Version: 1.0 Subject: Re: Review Request 39088: Made shell test locale-independent. From: "Jan Schlicht" To: "Till Toenshoff" , "Alexander Rojas" , "Jan Schlicht" Cc: "Benjamin Bannier" , "mesos" Date: Thu, 08 Oct 2015 09:52:43 -0000 Message-ID: <20151008095243.31883.97329@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jan Schlicht" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39088/ X-Sender: "Jan Schlicht" References: <20151007152435.31883.92484@reviews.apache.org> In-Reply-To: <20151007152435.31883.92484@reviews.apache.org> Reply-To: "Jan Schlicht" X-ReviewRequest-Repository: mesos --===============2200439559662741620== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/#review101883 ----------------------------------------------------------- Ship it! 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 961) s/LANG/LC_ALL At https://help.ubuntu.com/community/Locale it is stated that using `LANG` provides a default value if LC_* has not been set. Some distributions (e.g. Fedora) set LC_* explicitly. We have to use LC_ALL to make sure that it really is overwritten. - Jan Schlicht On Oct. 7, 2015, 5:24 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39088/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 5:24 p.m.) > > > Review request for mesos, Alexander Rojas, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3517 > https://issues.apache.org/jira/browse/MESOS-3517 > > > Repository: mesos > > > Description > ------- > > The test environment does not enforce that we run with a defined locale, > so instead enforce it for our particular use case (here: potentially > localized error messages from shell). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e > > Diff: https://reviews.apache.org/r/39088/diff/ > > > Testing > ------- > > With German locale installed: > > % LANG=de_DE.UTF-8 make check > > > Thanks, > > Benjamin Bannier > > --===============2200439559662741620==--