From reviews-return-11703-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Oct 7 21:29:26 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56CBE173DD for ; Wed, 7 Oct 2015 21:29:26 +0000 (UTC) Received: (qmail 22241 invoked by uid 500); 7 Oct 2015 21:29:26 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22217 invoked by uid 500); 7 Oct 2015 21:29:26 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22201 invoked by uid 99); 7 Oct 2015 21:29:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Oct 2015 21:29:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 192882A18AA; Wed, 7 Oct 2015 21:29:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4021836529288234160==" MIME-Version: 1.0 Subject: Re: Review Request 39102: Added documentation for JSON resources. From: "Neil Conway" To: "Greg Mann" , "Neil Conway" , "mesos" Date: Wed, 07 Oct 2015 21:29:25 -0000 Message-ID: <20151007212925.16483.76015@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Neil Conway" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39102/ X-Sender: "Neil Conway" References: <20151007191905.16483.91865@reviews.apache.org> In-Reply-To: <20151007191905.16483.91865@reviews.apache.org> Reply-To: "Neil Conway" X-ReviewRequest-Repository: mesos --===============4021836529288234160== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review101813 ----------------------------------------------------------- docs/attributes-resources.md (line 39) What's a "key string"? docs/attributes-resources.md (line 164) Wouldn't "--resources=`cat resources.txt`" be a bit more direct? docs/configuration.md (line 1431) Add link. - Neil Conway On Oct. 7, 2015, 7:19 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39102/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 7:19 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Added documentation for JSON resources. > > > Diffs > ----- > > docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 > docs/configuration.md 2ab476a2d2c43e309b570d73ecac80e27b296e7e > > Diff: https://reviews.apache.org/r/39102/diff/ > > > Testing > ------- > > Viewed the relevant documentation sections ('Attributes and Resources' & 'Configuration') using the mesos-website-container: https://github.com/mesosphere/mesos-website-container > > > Thanks, > > Greg Mann > > --===============4021836529288234160==--