From reviews-return-11599-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org  Tue Oct  6 20:05:57 2015
Return-Path: <reviews-return-11599-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7A4DB17593
	for <apmail-mesos-reviews-archive@minotaur.apache.org>; Tue,  6 Oct 2015 20:05:57 +0000 (UTC)
Received: (qmail 55637 invoked by uid 500); 6 Oct 2015 20:05:54 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 55613 invoked by uid 500); 6 Oct 2015 20:05:54 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 55601 invoked by uid 99); 6 Oct 2015 20:05:54 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2015 20:05:54 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 6030728D720;
	Tue,  6 Oct 2015 20:05:53 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============2718125454379866911=="
MIME-Version: 1.0
Subject: Re: Review Request 39056: Fix for Mesos master crash due to check
 failure.
From: "Mesos ReviewBot" <reviews@mesos.apache.org>
To: "Mandeep Chadha" <mandeep.chadha@yahoo.com>,
 "Mesos ReviewBot" <reviews@mesos.apache.org>,
 "mesos" <reviews@mesos.apache.org>
Date: Tue, 06 Oct 2015 20:05:53 -0000
Message-ID: <20151006200553.31883.43325@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/39056/
X-Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
References: <20151006175925.31884.48994@reviews.apache.org>
In-Reply-To: <20151006175925.31884.48994@reviews.apache.org>
Reply-To: "Mesos ReviewBot" <reviews@mesos.apache.org>
X-ReviewRequest-Repository: mesos

--===============2718125454379866911==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39056/#review101684
-----------------------------------------------------------


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos ReviewBot


On Oct. 6, 2015, 5:59 p.m., Mandeep Chadha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39056/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 5:59 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Check failed due to double comparison : MESOS-3552.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e 
> 
> Diff: https://reviews.apache.org/r/39056/diff/
> 
> 
> Testing
> -------
> 
> Added unit test.
> make check successful.
> 
> 
> Thanks,
> 
> Mandeep Chadha
> 
>


--===============2718125454379866911==--