From reviews-return-11554-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org  Tue Oct  6 11:46:13 2015
Return-Path: <reviews-return-11554-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 59B6B17D1B
	for <apmail-mesos-reviews-archive@minotaur.apache.org>; Tue,  6 Oct 2015 11:46:13 +0000 (UTC)
Received: (qmail 16694 invoked by uid 500); 6 Oct 2015 11:46:09 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 16643 invoked by uid 500); 6 Oct 2015 11:46:09 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 15801 invoked by uid 99); 6 Oct 2015 11:46:09 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2015 11:46:08 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 47B3E28D6C2;
	Tue,  6 Oct 2015 11:46:08 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============3424627867595623931=="
MIME-Version: 1.0
Subject: Re: Review Request 38950: Http Authenticators can be loaded as
 modules from mesos.
From: "Mesos ReviewBot" <reviews@mesos.apache.org>
To: "Till Toenshoff" <toenshoff@me.com>, "Adam B" <adam@mesosphere.io>,
 "Bernd Mathiske" <bernd@mesosphere.io>
Cc: "mesos" <reviews@mesos.apache.org>,
 "Alexander Rojas" <alexander@mesosphere.io>,
 "Mesos ReviewBot" <reviews@mesos.apache.org>
Date: Tue, 06 Oct 2015 11:46:08 -0000
Message-ID: <20151006114608.31884.73927@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/38950/
X-Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
References: <20151006085244.31883.71047@reviews.apache.org>
In-Reply-To: <20151006085244.31883.71047@reviews.apache.org>
Reply-To: "Mesos ReviewBot" <reviews@mesos.apache.org>
X-ReviewRequest-Repository: mesos

--===============3424627867595623931==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/#review101632
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37714, 37996, 37997, 37998, 37999, 38000, 38094, 38627, 38950]

All tests passed.

- Mesos ReviewBot


On Oct. 6, 2015, 8:52 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38950/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 8:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3232
>     https://issues.apache.org/jira/browse/MESOS-3232
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds support for modularization of HTTP Authenticators. 
> 
> It includes an example of how to do it with the Basic HTTP Authenticator.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION 
>   include/mesos/module/http_authenticator.hpp PRE-CREATION 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/examples/test_http_authenticator_module.cpp PRE-CREATION 
>   src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
>   src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
>   src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69 
>   src/tests/http_authentication_tests.cpp PRE-CREATION 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
>   src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f 
> 
> Diff: https://reviews.apache.org/r/38950/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


--===============3424627867595623931==--