From reviews-return-11552-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Oct 6 10:12:48 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 610B2179C6 for ; Tue, 6 Oct 2015 10:12:48 +0000 (UTC) Received: (qmail 22788 invoked by uid 500); 6 Oct 2015 10:12:32 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22766 invoked by uid 500); 6 Oct 2015 10:12:32 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22750 invoked by uid 99); 6 Oct 2015 10:12:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2015 10:12:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6B1A928D6B0; Tue, 6 Oct 2015 10:12:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4187190057659744755==" MIME-Version: 1.0 Subject: Re: Review Request 37023: Add an endpoint that exposes component flags. From: "Mesos ReviewBot" To: "Ben Mahler" Cc: "haosdent huang" , "Mesos ReviewBot" , "mesos" Date: Tue, 06 Oct 2015 10:12:31 -0000 Message-ID: <20151006101231.31883.61275@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37023/ X-Sender: "Mesos ReviewBot" References: <20151006041556.31883.51691@reviews.apache.org> In-Reply-To: <20151006041556.31883.51691@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============4187190057659744755== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/#review101628 ----------------------------------------------------------- Patch looks great! Reviews applied: [39037, 37023] All tests passed. - Mesos ReviewBot On Oct. 6, 2015, 4:15 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37023/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 4:15 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3104 > https://issues.apache.org/jira/browse/MESOS-3104 > > > Repository: mesos > > > Description > ------- > > Add an endpoint that exposes component flags. > > > Diffs > ----- > > src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 > src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c > src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b > src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b > src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 > src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c > > Diff: https://reviews.apache.org/r/37023/diff/ > > > Testing > ------- > > manual test wich mesos-local. > ``` > $ curl http://localhost:5050/master/flags 2>/dev/null|jq . > { > "flags": { > "allocation_interval": "1secs", > "allocator": "HierarchicalDRF", > "authenticate": "false", > "authenticate_slaves": "false", > "authenticators": "crammd5", > "framework_sorter": "drf", > "help": "true", > "initialize_driver_logging": "true", > "log_auto_initialize": "true", > "logbufsecs": "0", > "logging_level": "INFO", > "max_slave_ping_timeouts": "5", > "quiet": "false", > "recovery_slave_removal_limit": "100%", > "registry": "replicated_log", > "registry_fetch_timeout": "1mins", > "registry_store_timeout": "5secs", > "registry_strict": "false", > "root_submissions": "true", > "slave_ping_timeout": "15secs", > "slave_reregister_timeout": "10mins", > "user_sorter": "drf", > "version": "false", > "webui_dir": "/home/haosdent/mesos/build/../src/webui", > "work_dir": "/tmp/mesos", > "zk_session_timeout": "10secs" > } > } > ``` > > ``` > $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq . > { > "flags": { > "authenticatee": "crammd5", > "cgroups_cpu_enable_pids_and_tids_count": "false", > "cgroups_enable_cfs": "false", > "cgroups_hierarchy": "/sys/fs/cgroup", > "cgroups_limit_swap": "false", > "cgroups_root": "mesos", > "container_disk_watch_interval": "15secs", > "containerizers": "mesos", > "default_role": "*", > "disk_watch_interval": "1mins", > "docker": "docker", > "docker_kill_orphans": "true", > "docker_remove_delay": "6hrs", > "docker_socket": "/var/run/docker.sock", > "docker_stop_timeout": "0ns", > "enforce_container_disk_quota": "false", > "executor_registration_timeout": "1mins", > "executor_shutdown_grace_period": "5secs", > "fetcher_cache_dir": "/tmp/mesos/fetch", > "fetcher_cache_size": "2GB", > "frameworks_home": "", > "gc_delay": "1weeks", > "gc_disk_headroom": "0.1", > "hadoop_home": "", > "help": "false", > "initialize_driver_logging": "true", > "isolation": "posix/cpu,posix/mem", > "launcher_dir": "/home/haosdent/mesos/build/src", > "logbufsecs": "0", > "logging_level": "INFO", > "oversubscribed_resources_interval": "15secs", > "perf_duration": "10secs", > "perf_interval": "1mins", > "qos_correction_interval_min": "0ns", > "quiet": "false", > "recover": "reconnect", > "recovery_timeout": "15mins", > "registration_backoff_factor": "1secs", > "resource_monitoring_interval": "1secs", > "revocable_cpu_low_priority": "true", > "sandbox_directory": "/mnt/mesos/sandbox", > "strict": "true", > "switch_user": "true", > "version": "false", > "work_dir": "/tmp/mesos/0" > } > } > ``` > > > Thanks, > > haosdent huang > > --===============4187190057659744755==--