From reviews-return-11540-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org  Tue Oct  6 08:15:55 2015
Return-Path: <reviews-return-11540-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 858CA175A7
	for <apmail-mesos-reviews-archive@minotaur.apache.org>; Tue,  6 Oct 2015 08:15:55 +0000 (UTC)
Received: (qmail 80665 invoked by uid 500); 6 Oct 2015 08:15:55 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 80644 invoked by uid 500); 6 Oct 2015 08:15:55 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 80626 invoked by uid 99); 6 Oct 2015 08:15:55 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2015 08:15:55 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 741A928D67D;
	Tue,  6 Oct 2015 08:15:54 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============6482287620717925148=="
MIME-Version: 1.0
Subject: Re: Review Request 38579: Refactored registry client
From: "Mesos ReviewBot" <reviews@mesos.apache.org>
To: "Ben Mahler" <benjamin.mahler@gmail.com>,
 "Timothy Chen" <tnachen@apache.org>
Cc: "Jojy Varghese" <jojy@mesosphere.io>,
 "Mesos ReviewBot" <reviews@mesos.apache.org>,
 "mesos" <reviews@mesos.apache.org>
Date: Tue, 06 Oct 2015 08:15:54 -0000
Message-ID: <20151006081554.31884.84123@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/38579/
X-Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
References: <20151006023305.31883.19406@reviews.apache.org>
In-Reply-To: <20151006023305.31883.19406@reviews.apache.org>
Reply-To: "Mesos ReviewBot" <reviews@mesos.apache.org>
X-ReviewRequest-Repository: mesos

--===============6482287620717925148==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/#review101621
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39013, 38443, 38579]

All tests passed.

- Mesos ReviewBot


On Oct. 6, 2015, 2:33 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38579/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 2:33 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Cleanup and broke big methods into smaller chunks.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd 
>   src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c 
> 
> Diff: https://reviews.apache.org/r/38579/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


--===============6482287620717925148==--