From reviews-return-11433-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org  Mon Oct  5 18:08:57 2015
Return-Path: <reviews-return-11433-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 813CD18835
	for <apmail-mesos-reviews-archive@minotaur.apache.org>; Mon,  5 Oct 2015 18:08:57 +0000 (UTC)
Received: (qmail 89003 invoked by uid 500); 5 Oct 2015 18:08:57 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 88995 invoked by uid 500); 5 Oct 2015 18:08:57 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 88978 invoked by uid 99); 5 Oct 2015 18:08:56 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Oct 2015 18:08:56 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 1076F28D3AF;
	Mon,  5 Oct 2015 18:08:56 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============2214338343204369892=="
MIME-Version: 1.0
Subject: Re: Review Request 39002: Fixed sed command for Python protos
 generation.
From: "Anand Mazumdar" <mazumdar.anand@gmail.com>
To: "Anand Mazumdar" <mazumdar.anand@gmail.com>,
 "Joris Van Remoortere" <joris.van.remoortere@gmail.com>,
 "Marco Massenzio" <marco@mesosphere.io>
Cc: "Isabel Jimenez" <contact@isabeljimenez.com>,
 "mesos" <reviews@mesos.apache.org>
Date: Mon, 05 Oct 2015 18:08:56 -0000
Message-ID: <20151005180856.31884.30664@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Anand Mazumdar" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/39002/
X-Sender: "Anand Mazumdar" <noreply@reviews.apache.org>
References: <20151005174803.31884.62791@reviews.apache.org>
In-Reply-To: <20151005174803.31884.62791@reviews.apache.org>
Reply-To: "Anand Mazumdar" <mazumdar.anand@gmail.com>
X-ReviewRequest-Repository: mesos

--===============2214338343204369892==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39002/#review101501
-----------------------------------------------------------

Ship it!


Ship It!

- Anand Mazumdar


On Oct. 5, 2015, 5:48 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39002/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 5:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Marco Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The current command didn't complete the protobuf generation and resulted in an empty file.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e698927 
> 
> Diff: https://reviews.apache.org/r/39002/diff/
> 
> 
> Testing
> -------
> 
> make check and verified that protobufs were properly generated
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


--===============2214338343204369892==--