mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Peach" <jpe...@apache.org>
Subject Review Request 39800: Fix HDFS du output parsing.
Date Fri, 30 Oct 2015 03:12:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39800/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-3605
    https://issues.apache.org/jira/browse/MESOS-3605


Repository: mesos


Description
-------

- Swallow WARN log messages unless the command failed or we could
   not parse the output.
 - Make the actual du output parsing more reliable by not using
   human-readable format, scanning all the output lines, and
   tokenizing rather than splitting the output lines.


Diffs
-----

  src/hdfs/hdfs.hpp 18f17231b92b84d0b0e4e15837d0e44ce8758cdf 
  src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 

Diff: https://reviews.apache.org/r/39800/diff/


Testing
-------

make check. Manual testing with a framework that uses the fetcher with HDFS urls.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message