-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/#review104101
-----------------------------------------------------------
Ship it!
minus the removal of taskid quotations.
- Joris Van Remoortere
On Oct. 21, 2015, 2:37 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39497/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 2:37 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3772
> https://issues.apache.org/jira/browse/MESOS-3772
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Specifically, we should always quote executor IDs (because they are
> user-supplied and might contain whitespace), but we don't need to quote
> framework IDs. There's a bunch more work we could do here (e.g., escaping
> punctuation), but this is a start.
>
> Also fix a few style issues with usage of "<<" operators.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4
> src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598
> src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa
> src/slave/containerizer/isolators/network/port_mapping.cpp e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef
> src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3
> src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab
> src/tests/containerizer.cpp 451c7be0bfd668ccd3325964cafcc4cbac941a94
>
> Diff: https://reviews.apache.org/r/39497/diff/
>
>
> Testing
> -------
>
> make check, visual inspection.
>
>
> Thanks,
>
> Neil Conway
>
>
|