mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39496: Clarified libevent config error messages.
Date Mon, 26 Oct 2015 14:48:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39496/#review104015
-----------------------------------------------------------

Ship it!


This file is also copied in 3rdparty/libprocess, so we need to make these changes twice. I
did this in a follow up patch.


configure.ac (line 1485)
<https://reviews.apache.org/r/39496/#comment162204>

    none of the error messages append `library`, likely as it's implied by the prefix `lib`.
Let's leave it off here to stay consistent.



configure.ac (line 1487)
<https://reviews.apache.org/r/39496/#comment162207>

    How about `version 2+`?


- Joris Van Remoortere


On Oct. 20, 2015, 9:49 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39496/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 9:49 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Neil Conway.
> 
> 
> Bugs: MESOS-3501
>     https://issues.apache.org/jira/browse/MESOS-3501
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Clarified libevent config error messages to include required version.
> 
> 
> Diffs
> -----
> 
>   configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 
> 
> Diff: https://reviews.apache.org/r/39496/diff/
> 
> 
> Testing
> -------
> 
> `../configure --enable-libevent --enable-ssl` with the libevent libraries/headers in
various states of disrepair.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message