mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 39410: Added support for github to apply-reviews.py.
Date Fri, 23 Oct 2015 07:05:33 GMT


> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote:
> > support/apply-reviews.py, line 106
> > <https://reviews.apache.org/r/39410/diff/3/?file=1100642#file1100642line106>
> >
> >     it would be really nice if we could make our code work under both 2.7 and 3.x
Python ;)
> 
> Artem Harutyunyan wrote:
>     replaced this with `print(output)`, that should work in 3.x, correct?

yes, but only by mistake :)
(`(output)` is interpreted as a 1-tuple in 2.7 and `print` is still assumed to be without
parentheses - in 3.4, as a paren-surrounded string)

You will need to add (as the VERY FIRST line after the shebang):
```
from __future__ import print_function
```


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review103208
-----------------------------------------------------------


On Oct. 23, 2015, 6:18 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and
Vinod Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> -------
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message