mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.
Date Thu, 22 Oct 2015 18:35:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39383/#review103637
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp (line 37)
<https://reviews.apache.org/r/39383/#comment161697>

    Short note here. Because we're using the C standard I/O functions for now we're assuming
all paths are POSIX-formatted.
    
    We may change this now, but in case you are wondering whether this works on Windows, the
answer is yes.
    
    Also, you might be leery of committing this without tests. That's ok! We need this to
pull the FS tests out of `os_tests.cpp` though. The last function we will need to port to
get those tests functional on Windows is `rmdir`, and I'm almost done.


- Alex Clemmer


On Oct. 22, 2015, 5:40 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39383/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 5:40 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am ba2836a72ceee948cb43364e80ada9f132f33d04

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 7f70c9ea7d57634b5bfd40523ba37561ec92a09a

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/constants.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39383/diff/
> 
> 
> Testing
> -------
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows
10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message