mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.
Date Thu, 22 Oct 2015 17:25:49 GMT


> On Oct. 18, 2015, 5:13 p.m., Joris Van Remoortere wrote:
> > src/slave/state.hpp, line 132
> > <https://reviews.apache.org/r/39219/diff/3/?file=1099151#file1099151line132>
> >
> >     How is this compiling for you?

Per our discussion, this turns out to not manifested because (1) there is no template specialization
that would cause it to manifest in the CMake build, and (2) I didn't do a make clean before
I built this on my Ubuntu box.

It's good to know that I can't expect some errors to be caught until specialization though!
That blows my mind.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review103062
-----------------------------------------------------------


On Oct. 18, 2015, 6:40 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39219/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2015, 6:40 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633,
MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
>     https://issues.apache.org/jira/browse/MESOS-3615
>     https://issues.apache.org/jira/browse/MESOS-3627
>     https://issues.apache.org/jira/browse/MESOS-3628
>     https://issues.apache.org/jira/browse/MESOS-3629
>     https://issues.apache.org/jira/browse/MESOS-3630
>     https://issues.apache.org/jira/browse/MESOS-3631
>     https://issues.apache.org/jira/browse/MESOS-3633
>     https://issues.apache.org/jira/browse/MESOS-3658
>     https://issues.apache.org/jira/browse/MESOS-3659
>     https://issues.apache.org/jira/browse/MESOS-3660
>     https://issues.apache.org/jira/browse/MESOS-3693
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added support for `slave/state.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a 
>   src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab 
> 
> Diff: https://reviews.apache.org/r/39219/diff/
> 
> 
> Testing
> -------
> 
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS
X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message